Support passing ResourceRecord objects when creating new records
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will make for a "cleaner" and more error-prone solution. Remembering the parameters for the array can be hard
bennetgallein
changed the title
…/powerdns-php into feat/create-object-support
trizz
added
the
enhancement
|
Hi @bennetgallein , Thanks for your contribution! I'll take a deeper look at it today or at the start of next week, but at a first glance it looks very nice. Thanks again and have a nice weekend! |
|
Hey @trizz I'm back from vacation and ready to continue work on this if wanted :) Let me know |
trizz
changed the title
ResourceRecord objects when creating new records
trizz
approved these changes
Nov 20, 2023
|
Thanks for your contribution @bennetgallein! I've just tagged a release with this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As proposed in this discussion: #146 here would be an implementation for the mentioned.
Motivation and context
Keeping track of what parameters to give to the
createmethod can get complicated. By enabling the developer to pass Objects we enable a cleaner syntax + enable the usage of auto-complete and other IDE features.How has this been tested?
tests are passing, I have tested on 8.1 in my dev-env
Screenshots (if appropriate)
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!